symfony2admingenerator / AdmingeneratorGeneratorBundle

(old-legacy) Admingenerator for Symfony2, parse generator.yml files to build classes
http://symfony2admingenerator.org/
MIT License
360 stars 125 forks source link

Provide cache capacities on build process and ControllerListener #802

Closed sescandell closed 10 years ago

sescandell commented 10 years ago

The AdmingeneratorGeneratorBundle lacks of some performance issues on low performance disk access (for example: on network mounted drives).

This PR is just an import of some custom code used in some of my projects where I cache Admingenerator process repeated at each request (and using File Finder to identify which generator have to be used).

In my custom projects, I use "inheritance" mechanism to handle it. Here I try to find a way to introduce that feature without any BC Break.

Because this is a new feature, it will be merged into a new Minor branch (1.2)

Work can be easily duplicated into your projects for 1.1 and 1.0 versions if needed.

sescandell commented 10 years ago

Ready to merge.

Awaiting feedbacks.

/cc @loostro

ioleo commented 10 years ago

@sescandell This looks promising. Do you think you could adapt this PR for new-unstable repo?

I'll take a closer look tomorrow, but I think (if it's stable) we could bump the minor version (1.2) and release it.

sescandell commented 10 years ago

It is stable, I quickly tested it on one of my project... but please test it on your side too :)

Of course I'll provide the same for the new-unstable (almost stable). Work is in progress. Should be available tomorrow ;)

ioleo commented 10 years ago

@sescandell I've remoded the doctrine/common from composer.json as this is an optional dependency. Instead I've added a note to the doc.

sescandell commented 10 years ago

Hi @loostro

Now, it's not an optional dependency. It's a requirement, you need to have it.