symfony2admingenerator / GeneratorBundle

Admingenerator for Symfony. Parse YAML files to build customized backend.
MIT License
67 stars 29 forks source link

Knp menu bundle. #278

Closed yuriyzinchenko closed 8 years ago

yuriyzinchenko commented 8 years ago

Hi, in 2.1.0 version knplabs/knp-menu-bundle is removed, but in GeneratorBundle/Resources/views/Sidebar/layout.html.twig:

    {% block sidebar_menu %}
        {% if admingenerator_config('knp_menu_alias') is not null %}
            {{ knp_menu_render(admingenerator_config('knp_menu_alias')) }}
        {% endif %}
    {% endblock sidebar_menu %}

Should I add knplabs/knp-menu-bundle to my composer.json or it is a mistake? Thanks.

tobias-93 commented 8 years ago

@yuriyzinchenko As described in the original discussion (#245), it is optional. If you want to use it, I would recommend you read the cookbook article on it (https://github.com/symfony2admingenerator/GeneratorBundle/blob/master/Resources/doc/cookbook/knp-menu.md), but it is not necessary. You should not run into problems as long as you don't set the knp_menu_alias-config.

bobvandevijver commented 8 years ago

Also noted in the upgrade notes.

yuriyzinchenko commented 8 years ago

Thanks.