search

symfonycorp / connect

The SymfonyConnect official API SDK
https://connect.symfony.com/
MIT License
90 stars 40 forks source link

Renamed providerKey to firewallName #110

Closed javiereguiluz closed 3 years ago

javiereguiluz commented 3 years ago

While upgrading a Symfony app to 5.3, I saw this error:

1x: Since symfony/security-http 5.2:
Method "SymfonyCorp\Connect\Security\Authentication\Token\ConnectToken::getProviderKey()"
has been deprecated, rename it to "getFirewallName()" instead.

I've added that method, and renamed all private properties to $firewallName. There's still a $this->providerKey usage because I think we can't update that (the class extends from a Symfony class and gets the property from there).

Please note that I don't know if all this is correct and/or enough. Thanks!

fabpot commented 3 years ago

Thank you @javiereguiluz.

fabpot commented 3 years ago

merged and released