search

symfonycorp / connect

The SymfonyConnect official API SDK
https://connect.symfony.com/
MIT License
90 stars 40 forks source link

[RFR] Updated README.md #34

Closed tony-co closed 10 years ago

tony-co commented 10 years ago

Added php syntax coloring

lyrixx commented 10 years ago

This is not valid markdown. duplicate of #26

csarrazi commented 10 years ago

Just as a side note for everyone. We (meaning sensiolabs) use standard Markdown, and not github-flavoured Markdown, which only works on github, and not with with the standard publication toolchain.

stof commented 10 years ago

@csarrazi it really depends of what is the "standard publication toolchain". At least 75% of the PHP implementations of a markdown parser I know are supported github-flavored markdown (well, minus the part being specific to github like linking to commit hash, issues or users) either by default or through a configuration setting. And even MarkdownExtra (the official extension for the original PHP implementation) supports fenced code blocks if you use ~~~ instead of backticks (AFAIK, Github accepts both). and for other language, the support is probably as good. For instance, many languages (including PHP) have a binding to Sundown, which has been implemented and is used (or at least was used as they were talking about writing a replacement) by Github through the Ruby binding

lyrixx commented 10 years ago

Actually, @fabpot always reject this kind of PR. So I reject it too. He said it is not valid markdown. You know, he loves / respects standards ;)