search

symfonycorp / connect

The SymfonyConnect official API SDK
https://connect.symfony.com/
MIT License
90 stars 40 forks source link

Couldn't load image url with getBadge() method #38

Closed inalgnu closed 9 months ago

inalgnu commented 10 years ago

The following method set the link to badge's image

protected function getLinkToFoafDepiction(\DOMElement $element)
{
        return $this->getLinkNodeHref('./atom:link[@rel="foaf:depiction"]', $element);
}

however there is no reference to foaf:depiction in fixtures https://github.com/sensiolabs/connect/tree/master/tests/fixtures.

The badges images are always set to null.

Should this to be fixed on the SDK side?

ping @marcw @lyrixx

lyrixx commented 10 years ago

@marcw what do you think about thins one ? Should I update connect code base to use the /atom:link[@rel="foaf:depiction"] format, or should we fix the SDK to parse correctly the current XML ?

stof commented 10 years ago

@lyrixx should this be closed thanks to #37 or is there another issue ?

inalgnu commented 10 years ago

@stof it's another issue.

lyrixx commented 10 years ago

@stof yes, it's another issue. I want the advice of connect API creator ;)

lyrixx commented 10 years ago

As seen with @marcw (he's shy, we talk out of github) we need to change the SDK (the parser). If you want to do this, feel free to send me a new PR ;) Thanks.

lyrixx commented 2 years ago

@inalgnu Could we close this issue?