search

symfonycorp / connect

The SymfonyConnect official API SDK
https://connect.symfony.com/
MIT License
90 stars 40 forks source link

[RFR] Fixed Serialization of AbstractEntity #44

Closed tucksaun closed 10 years ago

tucksaun commented 10 years ago

Currently the serialisation of ConnectToken trigger the serialisation of ApiUser. However the serialisation of ApiUser is naive and nothing in particular is done. This leads to a really big string (~500 Kb in my case) and can lead to potential break (in my case only in production :/) because of the serialisation of SensioLabs\Connect\Api\Api. Moreover there is no advantage of serialising it as it's not usable afterwards (see #15).

lyrixx commented 10 years ago

Thank you @tucksaun.

lyrixx commented 10 years ago

v2.1.0 released

tucksaun commented 10 years ago

great! thank you @lyrixx