search

symfonycorp / connect

The SymfonyConnect official API SDK
https://connect.symfony.com/
MIT License
91 stars 40 forks source link

Nullable $message argument for OAuthException #92

Closed guillbdx closed 4 years ago

guillbdx commented 4 years ago

This change will fix an issue: in src/Security/Firewall/ConnectAuthenticationListener.php at line 65, we create an OAuthException with $request->query->get('error_description') as a second argument. But this can be null in the $request query doesn't carry any error_description parameter.

If $message is null, then its value will be set to 'no message provided' at line 25.

fabpot commented 4 years ago

Good catch, I think I prefer to fix the calling code instead, see 47464f340e603727a49fdcc12d3847bfeb70e00a