search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.44k stars 147 forks source link

Add find_package(spdlog) to CMakeLists.txt #162

Closed oursland closed 2 years ago

oursland commented 2 years ago

On macOS (possibly others), the brew-installed spdlog and its CMake targets are not automatically available without first calling find_package(spdlog). This commit adds that call.

aaron-skydio commented 2 years ago

I think what we probably want to do here is just remove spdlog from the manifest, since it's unused (same for eigen and catch2). If we do want to add it here we'd need to gate this on whether SYMFORCE_BUILD_OPT is on (and it should already find spdlog if that option is on, if that's not working it's possible something else is broken)

aaron-skydio commented 2 years ago

Thanks for reporting - I think #166 should fix this and more generally avoid these kinds of issues