search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.41k stars 145 forks source link

Define SKYMARSHAL_PRINTING_ENABLED by default #179

Closed aaron-skydio closed 2 years ago

aaron-skydio commented 2 years ago

Describe the bug In 06be0d834d911b7afd199c31dcf0c6acc4687242 we removed our custom printers for key_t, but didn't define SKYMARSHAL_PRINTING_ENABLED. We could just mark key_t as #cpp_display_everywhere, but I think we do actually just want to enable printing by default

To Reproduce Run a modified optimizer test that emits a warning with some keys in it, like here: https://github.com/symforce-org/symforce/pull/178. It'll print them as FORMATTING_DISABLED

Expected behavior Prints the keys