symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.41k stars 145 forks source link

Add format_matrix_subscript_accessor and update_template_data to CodegenConfig #186

Closed gareth-cross closed 1 year ago

gareth-cross commented 2 years ago

This review adds two small methods to CodegenConfig, with the intention of making it easier to support additional languages:

aaron-skydio commented 2 years ago

I think we'll need to remove the format_matrix_subscript_accessor change from here since it's a duplicate with #190 which makes the other required changes with matrix_is_1d and have this PR just make the update_template_data change