search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.41k stars 145 forks source link

Use sf.sympy.Eq in symbolic_computation_speedups.ipynb #205

Closed aaron-skydio closed 2 years ago

aaron-skydio commented 2 years ago

Fixes #204

bradley-solliday-skydio commented 2 years ago

Is there a reason we don't just add Eq to symforce.symbolic directly? (Considering we already have Add, Mul, and the like).

aaron-skydio commented 2 years ago

Mostly because it isn't something that's typically supposed to be used with symforce, the logical operations that should be used are the ones in logic.py? Seems potentially misleading/confusing to import the builtin ones, and I sort of think it's nbd since they're pretty easily accessible on sf.sympy. Not a strong opinion though

bradley-solliday-skydio commented 2 years ago

Okay. That makes sense.