search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.44k stars 147 forks source link

Concepts link was not including end parenthesis #214

Closed kristen-skydio closed 1 year ago

kristen-skydio commented 2 years ago

Small change to use encoded character which appears to work. Sorry for the nit. It was misdirecting me to https://en.wikipedia.org/wiki/Concept_(generic_programming

aaron-skydio commented 2 years ago

This actually seems to break the markdown handling in the generated docs? Curious what environment you were seeing the broken link in image

kristen-skydio commented 2 years ago

I'm seeing it within github

There's a hanging closing parenthesis: broken_link

And if you see the address of the link, it's missing it's closing parenthesis broken_link_2

aaron-skydio commented 2 years ago

Huh, yep that's definitely wrong. We might have to play around a bit to find something that works both on github and other notebook renderers and in the docs? @bradley-solliday-skydio wanna take a look at this?

aaron-skydio commented 1 year ago

I think github must have fixed their markdown renderer so this is no longer necessary - this looks right to me now in both the symforce docs and github on main