search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.41k stars 145 forks source link

Fix warnings #222

Closed aaron-skydio closed 2 years ago

aaron-skydio commented 2 years ago

Turn on -Wall, -Wextra, and -Werror, and fix all of them

Marking LCM C++ bindings, lcm_coretypes.h, generated test data (because it contains LCM C++ bindings) as system includes so we don't fail the build on warnings in them (which do exist).

The build should both now be warning-free (except for third-party code), and fail if new warnings appear.

Reviewers: hayk-skydio,bradley-solliday-skydio,nathan-skydio Topic: sym-warnings

aaron-skydio commented 2 years ago

Reviews in this chain: └https://github.com/symforce-org/symforce/pull/222 Fix warnings

aaron-skydio commented 2 years ago
# head base diff date summary
0 becb8e24 716befd8 diff Sep 14 1:27 AM 58 files changed, 286 insertions(+), 78 deletions(-)
1 64f9de59 716befd8 diff Sep 14 11:37 AM 3 files changed, 5 insertions(+), 7 deletions(-)
aaron-skydio commented 2 years ago

Merged by 6d1c918d7f4a0f645e68be8fd060754d16c1c408