search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.44k stars 147 forks source link

Update Catch2 to v3.1.1; Test on ubuntu jammy #253

Closed bradley-solliday-skydio closed 2 years ago

bradley-solliday-skydio commented 2 years ago

This version of Catch2 doesn't have the same issues that sometimes causes v3.0.1 to fail to compile with older ubuntu versions/compiler versions.

Moreover, it also can compile with newer compilers (like gcc-11) on ubuntu jammy.

So, adding ubuntu jammy to the test_editable_pip_install and ci github action workflows.

Fixes #132

bradley-solliday-skydio commented 2 years ago

Note, I'm not confident the gcc-5 build will succeed on Jammy (as I wouldn't be surprised if apt-geting it failed). If it does fail, I intend to just remove those tests from the build matrix (unless someone objects, in which case I could try to figure out how to get a hold of gcc-5 on jammy).

bradley-solliday-skydio commented 2 years ago

Updated: more context in the new commit message.