symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.44k stars 147 forks source link

find_package fmt should have a version number #270

Closed chao-qu-skydio closed 1 year ago

chao-qu-skydio commented 1 year ago

Currently if someone has fmt 9 installed then symforce will find that version and fail to compile because fmt 9 deprecates ostream. So we should specify a version in find_package fmt

Slightly related is that spdlog also tries to find fmt and somehow finds fmt 9 and fails to compile.

aaron-skydio commented 1 year ago

Fixed by f9c21ad