symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.41k stars 145 forks source link

Add explicit instantiation declaration for Values #297

Closed bradley-solliday-skydio closed 1 year ago

bradley-solliday-skydio commented 1 year ago

For some reason this was missing (despite the fact that we explicitly instantiate the class in values.cc)

Speculation, but this might be why values.h always takes so long to compile.

Topic: values_explicit_instantiation_declaration

bradley-solliday-skydio commented 1 year ago

Reviews in this chain: └https://github.com/symforce-org/symforce/pull/297 Add explicit instantiation declaration for Values

bradley-solliday-skydio commented 1 year ago
# head base diff date summary
0 297d6afd 59753592 diff Feb 9 20:00 PM 1 file changed, 4 insertions(+)
aaron-skydio commented 1 year ago

Merged into 596e3bc45133f6e88760356081ffd81fdd3aa4bd