Should make it impossible to attempt something like
auto p = sym::Pose3();
p.Position().x() = 5;
Currently this is a noop (because Position() returns a temporary). We want the geo types to remain immutable (for conceptual simplicity), making the return value const makes this a compile error.
It's possible there are more things which should have const return values (all generated functions that return eigen types?), and it may or may not be easier to just do all of those.
Should make it impossible to attempt something like
Currently this is a noop (because
Position()
returns a temporary). We want the geo types to remain immutable (for conceptual simplicity), making the return valueconst
makes this a compile error.It's possible there are more things which should have const return values (all generated functions that return eigen types?), and it may or may not be easier to just do all of those.