search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.41k stars 145 forks source link

Fix symengine_wrapper search #342

Closed aaron-skydio closed 1 year ago

aaron-skydio commented 1 year ago

So that it works on different platforms that e.g. use local/lib or site-packages.

We were doing this correctly for editable installs but not non-editable installs

Longer-term I'm leaning more and more towards requiring building our copy of symengine separately first, but this is an easy strict improvement for now

Fixes #330

Topic: sf-wrapper-glob Reviewers: bradley,nathan,chao,ryan-b

aaron-skydio commented 1 year ago

Reviews in this chain: └https://github.com/symforce-org/symforce/pull/342 Fix symengine_wrapper search

aaron-skydio commented 1 year ago
# head base diff date summary
0 5c892165 0940fa5b diff Jun 2 13:04 PM 1 file changed, 24 insertions(+), 13 deletions(-)
1 76c69d3a 0940fa5b diff Jun 2 13:20 PM 1 file changed, 4 insertions(+), 2 deletions(-)
2 5bc6e9b1 0940fa5b diff Jun 2 13:35 PM 1 file changed, 1 insertion(+), 1 deletion(-)
3 71349254 0940fa5b diff Jun 2 14:15 PM 1 file changed, 1 insertion(+), 1 deletion(-)
jieyeo-skymul commented 1 year ago

Hi, I am still unable to build commit 71349254.

I am on macOS Ventura 13.4 trying to install Symforce on a Ubuntu 22.04.2 virtual machine with the following:

Python 3.10.6 gcc 11.3.0 g++ 11.3.0 pip 23.1.2

The error seems to say:

file INSTALL cannot set permissions on "/usr/include": Operation not permitted.

Would you have any idea what the issue might be and how to fix it? I see the commit passed the CI/test-on-ubuntu (ubuntu-22.04, python3.10, gcc-11, g++-11) which seems to be the same as what I have so I'm not sure why I am running into an error.

(edit: I just managed to install it with pip install -e . rather than pip install .)

aaron-skydio commented 1 year ago

That looks like #332 , I'm going to assume this fix works for #330