Standard practice is to set -Werror in environments like CI so that it fails the build there, but not default it on for all builds, so that users have the best chance of building successfully on compilers not tested by CI that emit different warnings.
We should probably just turn off -Wall and -Wextra outside CI as well, and possibly get rid of SYMFORCE_COMPILE_OPTIONS, but I'm leaving that for now.
Fixes #369
Standard practice is to set
-Werrorin environments like CI so that it fails the build there, but not default it on for all builds, so that users have the best chance of building successfully on compilers not tested by CI that emit different warnings.We should probably just turn off
-Walland-Wextraoutside CI as well, and possibly get rid ofSYMFORCE_COMPILE_OPTIONS, but I'm leaving that for now.