symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.44k stars 147 forks source link

Remove Werror from CMakeLists #370

Closed aaron-skydio closed 1 year ago

aaron-skydio commented 1 year ago

Fixes #369

Standard practice is to set -Werror in environments like CI so that it fails the build there, but not default it on for all builds, so that users have the best chance of building successfully on compilers not tested by CI that emit different warnings.

We should probably just turn off -Wall and -Wextra outside CI as well, and possibly get rid of SYMFORCE_COMPILE_OPTIONS, but I'm leaving that for now.