search

symforce-org / symforce

Fast symbolic computation, code generation, and nonlinear optimization for robotics
https://symforce.org
Apache License 2.0
1.44k stars 147 forks source link

Build fails due to spaces in directory paths #400

Open Aterolite24 opened 1 month ago

Aterolite24 commented 1 month ago

Describe the bug

When building the project in a directory path that contains spaces, the build process fails due to improper handling of spaces in directory paths. The path is interpreted incorrectly, causing the build to stop with errors related to path formatting.

For example, a directory like C:/Users/Username/My Projects/Symforce causes build failures, as spaces are not properly escaped or quoted.

To Reproduce

Steps to reproduce the behavior:

  1. Clone the repository into a directory that contains spaces, e.g., C:/Users/Username/My Projects/Symforce.
  2. Attempt to build the project with the following command: 
    python setup.py build
# or 
make px4_sitl_default none_iris
  3. Observe the build failure due to improper path handling.

Expected behavior

The build process should correctly handle directory paths with spaces by escaping or quoting the paths properly, allowing the build to proceed without errors.

Screenshots

N/A (Optional if you want to include terminal screenshots showing the error.)

Environment (please complete the following information):

Aterolite24 commented 1 month ago

401 gives my approach to solve the problem. Thanks.

aaron-skydio commented 1 month ago

Thanks for reporting - generally building on Windows isn't something we support or test in CI, but it sounds like this is probably a cross-platform problem anyway. Building by invoking setup.py directly is also deprecated by setuptools and not supported, but that's also probably not the issue.

Do you have the output of an example build failure? If not we'll see if we can reproduce.

Aterolite24 commented 1 month ago

Ahh I actually changed my setup.py since then .. and the issue was solved actually so .. 😅

On Tue, Sep 24, 2024, 12:26 AM Aaron Miller @.***> wrote:

Thanks for reporting - generally building on Windows isn't something we support or test in CI, but it sounds like this is probably a cross-platform problem anyway. Building by invoking setup.py directly is also deprecated by setuptools https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ and not supported, but that's also probably not the issue.

Do you have the output of an example build failure? If not we'll see if we can reproduce.

— Reply to this email directly, view it on GitHub https://github.com/symforce-org/symforce/issues/400#issuecomment-2369114283, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4ABMTHTSID5CMDN2N3G6CDZYBP5NAVCNFSM6AAAAABOSJ34JCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRZGEYTIMRYGM . You are receiving this because you modified the open/close state.Message ID: @.***>