Closed Inkrementator closed 7 months ago
It doesn't work in CI either.
dub test
now works on my machine. Instead of what I did in e3b4c40 , I suggest that the test should just check if it finds "AttributeError" to be forward and backwards compatible with python upgrades.
make test still fails after setting python to version 3.11, with a ton of input errors
And to make auditing f3d39e1 easier, here the steps to reproduce.
From git root:
fd dub.selections.json -X sed -Ei 's/("pyd": "0.14.)3"/\14/'
and from examples:
fd dub.sdl -X sed -i '/configuration "python38" {/ {
iconfiguration "python311" {
i\\ targetPath "lib/pyd"
i\\ lflags "-L$PYTHON_LIB_DIR"
i\\ dependency "autowrap:pyd" path="../../"
i\\ subConfiguration "autowrap:pyd" "python311"
i}
i
iconfiguration "python310" {
i\\ targetPath "lib/pyd"
i\\ lflags "-L$PYTHON_LIB_DIR"
i\\ dependency "autowrap:pyd" path="../../"
i\\ subConfiguration "autowrap:pyd" "python310"
i}
i
iconfiguration "python39" {
i\\ targetPath "lib/pyd"
i\\ lflags "-L$PYTHON_LIB_DIR"
i\\ dependency "autowrap:pyd" path="../../"
i\\ subConfiguration "autowrap:pyd" "python39"
i}
i
}'
Note: To get make test
to run, in addition to setting it to the right pythonversion, I have to set LD_LIBRARY_PATH="$PYTHONPATH" in the makefile rules.
edit: Done this in afac5dd
All right, make test
now runs on my machine with the following environment:
export DUB_CONFIGURATION=python311
export PYTHON_LIB_DIR=/lib/python3.11
export PYD_LIBPYTHON=python3.11
make test
I guess the one thing left now would be to update CI to actually test the different python versions, but I won't/ can't do that.
CI fails because e3b4c40, it should work now.
Sorry for all the back and forth, I'll set up the right python environments on the weekend.
CI is still red.
I've set up a python 3.8 environment and can't reproduce it, it works on my machine.
My dmd version is v2.108.0, so different from the one set in CI.
In the CI report, the step "python env vars", it also sets LD_LIBRARY_PATH, so maybe I was overwriting it.
I'm also not entirely sure I got the quoting right in d5f51f0 because I'm not sure if make has any special rules regarding variables and quoting. Works on my machine...
Note: Unittests don't compile on my machine, but I think it's unrelated to my changes
And as in the commit msg: I only tested some cherrypicked examples, but they worked.