sympa-community / sympa

Sympa, Mailing List Management Software
https://www.sympa.community/sympa
GNU General Public License v2.0
243 stars 97 forks source link

Inconsistent entries in parameter_usage column of "Skins, CCS and colors" entry of Listmaster Admin menu #1297

Open qosobrin opened 2 years ago

qosobrin commented 2 years ago

Version

sympa-6.2.66 debian 11 apache 2.4.51

Installation method

From source ./configure --build=x86_64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --disable-option-checking --disable-silent-rules --libdir=${prefix}/lib/x86_64-linux-gnu --libexecdir=${prefix}/lib/x86_64-linux-gnu --runstatedir=/run --disable-maintainer-mode --disable-dependency-tracking --enable-fhs --sysconfdir=/etc/sympa --sbindir=/usr/lib/sympa/bin --libexecdir=/usr/lib/sympa/bin --with-cgidir=/usr/lib/cgi-bin/sympa --with-staticdir=/usr/share/sympa/static_content --with-cssdir=/var/lib/sympa/css --with-picturesdir=/var/lib/sympa/pictures --datadir=/usr/share --localedir=/usr/share/locale --mandir=/usr/share/man --with-unitsdir=/usr/lib/systemd/system --without-initdir --docdir=/usr/share/doc/sympa --with-piddir=/run/sympa --with-perl=/usr/bin/perl --with-user=sympa --with-group=sympa --with-aliases_file=/etc/mail/sympa/aliases --disable-setuid-fcgi

Expected behavior

All entries in this column should have a similar format, capitalization should be used always in the same way and there are several entries that refer to the same concept.

Actual behavior

Well, the actual behavior is not what I described above.

Additional information

I propose all entries should start with any of these texts ("Background color of:", "Font color of:" or "Border color of:") followed by the element or list of elements affected. So these are the texts that I propose:

color_0:

Background color of:
    Text

color_1:

Font color of:
    Miscellaneous texts

color_2:

Font color of:
    Titles text
Background color of:
    Buttons

color_3:

Font color of:
    Main text

color_4:

Font color of:
    Form labels
    Side menu titles
    Text areas in forms

color_5:

Background color of:
    HTTP links
    Hovered buttons

color_6:

Font color of:
    Hovered links
Backgorund color of:
    Buttons

color_7:

Font color of:
    Navigation links
    Buttons text

color_8:

Background color of:
    Tables
    Notice messages

color_9:

Border color of:
    Tables

color_10:

Background color of:
    List configuration edition
    Navigation edition links

color_11:

Background color of:
    Current list configuration edition
    Current navigation edition links

color_12:

Border color of:
    Form elements
Background color of:
    Disabled form elements

color_13:

Background color of:
    Invalid form elements

color_14:

Background color of:
    Ins and mark elements

color_15:

Background color of:
    Selected text

However there are some entries that I think should be more clearly explained:

I you wish I can make the appropriate changes in the skinsedit.tt2 file, but before commiting them I would like to solve these questions that I propose in the second half of this "bug report".

ikedas commented 2 years ago

The colors are not always used as described. I think whether we should fix the usage (in css.tt2) or the explanation (in skinsedit.tt2) depends on the case.

EDIT: Clarified template files.