search

sympa-community / sympa

Sympa, Mailing List Management Software
https://www.sympa.community/sympa
GNU General Public License v2.0
243 stars 97 forks source link

sympa.pl - family instantiation - "--quiet" option has no effect on progress bar #1567

Closed jfaedi closed 9 months ago

jfaedi commented 1 year ago

Version

6.2.70

Installation method

source package

Expected behavior

./sympa.pl --instantiate_family=${family} --robot=${robot} --input_file=${xml_input_file} --close_unknown --quiet

Actual behavior --------------- ./sympa.pl --instantiate_family=${family} --robot=${robot} --input_file=${xml_input_file} --close_unknown --quiet List "xxxxx" (1/1) created/updated Creating lists: 100% [===========================================================================================]D 0h00m01s Steps to reproduce ------------------ Instantiate a famliy and use "--quiet" option Additional information ---------------------- The problem is in "lib/Sympa/CLI/instantiate.pm" near line 134 where "silent" arg sholud be used when creating $progress object like that: ``` perl $progress = Term::ProgressBar->new( { name => 'Creating lists', count => $total, ETA => 'linear', silent => $options{quiet} } ); ```
ikedas commented 1 year ago

Hi @jfaedi , thanks for reporting bug!

Though I've not confirmed yet, the PR above could fix the problem. --- However it is the fix against 6.2.71b.1: Recently CLI of Sympa had been changed much.