search

sympa-community / sympa

Sympa, Mailing List Management Software
https://www.sympa.community/sympa
GNU General Public License v2.0
241 stars 95 forks source link

List inclusion in data_source displaying random string #1695

Open laerm opened 1 year ago

laerm commented 1 year ago

While looking into a list inclusion issue for a user, I noticed the members of a list added via an inclusion show a random string in the sources column, for example "05c07645".

Version

v6.2.72 on RHELv7.9

Installation method

Via EPEL repo

Expected behavior

I can't remember if previous version showed the included list name, or something else under the sources column of the member page.

Actual behavior

Some sort of hash, for example "05c07645" is displaying under the sources column of the member page.

Steps to reproduce

Go to members page of a list which includes another list:

image

Thank you @ikedas as usual for your work and help, it is very much appreciated.

ldidry commented 1 year ago

Did you add a name to your inclusion source? I didn’t try on 6.2.72, but in 6.2.68, I have the name of the inclusion source instead of this hash-thing. I guess that the hash-thing might be a random name chosen if you didn’t specify a name.

laerm commented 1 year ago

Bonjour @ldidry !

No, the name was empty. I just added a name, forced a sync... and the name appears! Thank you! I honestly can't remember how previous Sympa versions behaved, I only noticed this now when diving into another issue raised by a user of ours.

Maybe you should force the user to add a name when adding a source, to avoid this display issue? Obviously not a life changing bug :)

ikedas commented 1 year ago

Hi @laerm ,

In the past, even if a name was set, it was not always displayed. Sympa around 6.2.46 has been improved to always display the names of data sources. So, even those without a name are now required to have a name to be deiplayed.

It would be a problem if the list would no longer work without a data source name, otoh displaying such as "no name" would not distinguish the data sources. That's why the random names by data sources are displayed.

If you have suggestions on how to make life better, please suggest them.

laerm commented 1 year ago

Hi @ikedas ,

If a name is specified, display the name ("This is list B"), otherwise simply display the actual name of the included list ("listb").