search

sympa-community / sympa

Sympa, Mailing List Management Software
https://www.sympa.community/sympa
GNU General Public License v2.0
237 stars 95 forks source link

Revisiting distribute moderation URI creates unnecessary mail to listmaster #1743

Open woodfighter opened 7 months ago

woodfighter commented 7 months ago

Version

6.2.72

Installation method

FreeBSD Ports

Expected behavior

When revisiting a moderators message distribution link like https://sympa.example.org/sympa/distribute/listname/d3b07384d113edec49eaa6238ad5ff00 after the message has already been distributed, the user is presented with an error message like “ERROR (distribute) - Unable to access the message on list listname with key d3b07384d113edec49eaa6238ad5ff00. Warning: this message may already have been sent by one of the list's moderators.”

Actual behavior

Additionally a mail message is created 

X-Sympa-Auth-Level: md5
X-Sympa-Message-ID: <sympa.1111111111.222222.33333.444@sympa.example.org>
X-Sympa-Sender: username@sympa.example.org
Return-Path: <sympa-request@sympa.example.org>
Content-Type: text/plain; Charset=utf-8

which then ends up in the msg/bad folder and creates a mail to sympa-request, that a message without command was sent.

Steps to reproduce

Send a message to a moderated list and try to distribute it multiple times via the link in the mail.

Additional information