sympa-community / sympa

Sympa, Mailing List Management Software
https://www.sympa.community/sympa
GNU General Public License v2.0
237 stars 94 forks source link

Setting invite sender as From: violates modern sender authentication #1846

Open adam12b1 opened 1 month ago

adam12b1 commented 1 month ago

Version

Sympa 6.2.72

Installation method

FreeBSD port

Expected behavior

Invite emails should successfully reach their destination.

Actual behavior

These invites will be filtered or blocked in many cases, because they are sending From: the person doing the invitation. Assuming that person's email is not hosted on the same system as the Sympa lists, sender authentication will fail.

Additional information

The fix (or one possible fix) is extremely simple: just remove the From: line from the mail_tt2/invite.tt2 file. That way, the invite will go out with the default Sympa administrative sender address, code>sympa@lists.domain.org</code (or whatever domain the Sympa server lives in), which will pass sender authentication checks.

# diff -c invite.tt2~ invite.tt2
*** invite.tt2~ Sun Mar 31 20:18:16 2024
--- invite.tt2  Tue May 28 16:04:12 2024
***************
*** 1,5 ****
  [%# invite.tt2 ~%]
- From: [% requested_by %]
  Reply-To: [% conf.email %]@[% domain %]
  Subject: [%"Invitation to join list %1"|loc(list.name)|qencode%]

--- 1,4 ----
ikedas commented 2 weeks ago

Hi @adam12b1 , thank you for your contribution! I'll review your changes and, if possible, will add something. Please wait for a few weeks.