sympa-community / sympa

Sympa, Mailing List Management Software
https://www.sympa.community/sympa
GNU General Public License v2.0
248 stars 99 forks source link

delivery notification to sender for moderated mailing lists #965

Open Salo15 opened 4 years ago

Salo15 commented 4 years ago

In a moderated mailing list, when an email is confirmed via the Web page, no delivery notification is sent to the sender. When a mail is released by clicking on the link in the moderation mail, a delivery notification is sent to the sender.

Version

6.2.16

Installation method

Debian Package

Expected behavior

When an e-mail is confirmed via the website a Delivery Notification should also be sent.

Actual behavior

In this case, the sender is not notified that his e-mail was sent via the list.

Additional information

After releasing a mail via the website, I see an entry in the log that looks something like this: ... sympa_msg[1756]: notice Sympa::Request::Message::__parse() Parsing: QUIET DISTRIBUTE listname b49a958147967afxxxxxxxxxxxxxxxxxxx

So the command "distribute" is called with a "Quiet" in front of it. At what point do I have to change something so that when releasing a mail via the website the command "distribute" is executed without "quiet" and thus a response is sent to the sender?

We have moderators who deliberately moderate their mailing list via the website. They would like to keep this procedure and they still want a delivery notification to be sent to the sender.

ikedas commented 4 years ago

Even on recent version (6.2.56) "quiet" option is hardcoded in web interface. So I added "enhancement" tag to note that improvement is requested.

Salo15 commented 4 years ago

Thanks for your quick response. Is there a possibility that we ourselves change the corresponding line in the code so that a delivery notification is also sent to the sender when mail is released via the website?

ikedas commented 4 years ago

On 6.2.16, I think this change may enable notification always:

diff --git a/src/cgi/wwsympa.fcgi.in b/src/cgi/wwsympa.fcgi.in
index 810917d..87e173b 100644
--- a/src/cgi/wwsympa.fcgi.in
+++ b/src/cgi/wwsympa.fcgi.in
@@ -8970,7 +8970,7 @@ sub do_distribute {
             next;
         }
         push @mail_command,
-            sprintf('QUIET DISTRIBUTE %s %s', $list->{'name'}, $id);
+            sprintf('DISTRIBUTE %s %s', $list->{'name'}, $id);

         # TAG
         if ($list_topics) {
Salo15 commented 4 years ago

Thank you very much. That helps for the moment and it would be great if that would be implemented in future versions.

laerm commented 3 years ago

I have a user that has just noticed this discrepancy between web interface and email moderation, it seems it is still present in latest release 6.2.64. It would be great if this could be corrected!

laerm commented 1 year ago

Still present in 6.2.70. Is it planned to add this change into the main release?

laerm commented 1 year ago

@ikedas still not in the latest release 6.2.72. Could this be added to the next release? It's a bit annoying having to manually fix the code after each upgrade. Thanks for your tireless work.