symphonicc / multer-azure-blob-storage

ES6 & Typescript friendly multer storage engine for Azure's blob storage.
MIT License
19 stars 25 forks source link

Interface 'MulterInFile' incorrectly extends interface 'File'. Types of property 'stream' are incompatible. #20

Closed krupalraj closed 3 years ago

krupalraj commented 4 years ago

image

guys anyone knows about this error?

multer-azure-blob-storage : v1.0.2

brunohsn6 commented 3 years ago

I'm having the same issue! have you figured out a way to fix it? @krupalraj

juicycool92 commented 3 years ago

any update on this issue? i having same issues

juicycool92 commented 3 years ago

apparently, this issues are occurs when call this module from typescript. Node v12. stream variables in interface MulterInFile's dataType is cannot not recognize. seems like @types/multer or multer 's Request.File type are change? anyway, i change MulterInFile's stream dataType from Stream to Readable and it's looking work properly.

my next question is..

  1. how do i test this change is not causing any other issue?
  2. how do i make a branch and merge request?
marcoshw commented 3 years ago

Any news with this? i dont know how to fix it

Sliverb commented 3 years ago

Sorry guys. Fixing this now

Sliverb commented 3 years ago

This has been fixed and published on v1.1.0