Open twiro opened 9 years ago
Maybe @jonmifsud 's filtering additions could also be included in that release
Just noticed that the whole "association filters"-concept probably won't be implemented before Symphony 3.0.0. ( https://github.com/symphonycms/symphony-2/issues/2322#issuecomment-74543417 )
So that PR wouldn't need to be part of a possible 1.3.3-Release. Am I getting this right @jonmifsud ?
_(Though I already tested your filtering-branch in a current S.2.6.2-project and it solved some javascript-problems that the regular 1.0.0.beta had ( https://github.com/hananils/association_ui_selector/issues/47 ) Will need to check if these bugs are fixed in the new 1.0.0-release )_
@twiro yes correct - but I might be re-evaluating the core requirement / implementation and maybe find a workaround. I've submitted a separate PR for filtering via delegate which might mean I can move the current 'filtering branch' into a separate extension which handles that exclusively.
Thank you very much for the 1.0.0-Release @nilshoerrmann ! About time to get this out of beta ;)
I would like to propose to align version numbers (and therefore (basic) commits/fixes) of this extension to the ones of the original SBL-Repo as long as both versions coexist (which ain't a perfect state, as the whole idea of association field was to enhance and replace SBL, but seems to be the way things are for now (Symphony 2.X).
I have checked the additions to the 1.0.0-Release and have 4 additional SBL-Commit-Backports left, that seem to not be included yet:
What about merging these, adding a readme (at least a short one - could help with that one if no native english speaker wants to jump in) and release a 1.3.3-Version that matches the current latest SBL-Version?
Any thoughts @brendo , @nilshoerrmann ?
Maybe @jonmifsud 's filtering additions could also be included in that release: