search

symphonists / cachelite

Dead simple caching extension for the Symphony CMS. Uses the CacheLite library.
Other
19 stars 11 forks source link

Version 1.3: Merge Integration #24

Closed nitriques closed 10 years ago

nitriques commented 10 years ago

This PR is for review and tests.

It should fix issues #9, #20 and #22.

I've also added a better 'GET' detection (6fd0f5e1b502a13b7db1e8e8af1a5c8641b38b5c) and added Added X-Frame-Options and Access-Control-Allow-Origin headers (155659171535eda872c62c79ebdfb3cedc96d56e). I've tested it and everything seems to be working well.

nitriques commented 10 years ago

@brendo Can I merge this in ? Anybody (@michael-e) tested it ?

michael-e commented 10 years ago

Nope, I haven't. I have never used CacheLite, so in this case I can't help with breaking it. :-)

nitriques commented 10 years ago

@michael-e oh ok thanks. Do you know who should I ping ?

michael-e commented 10 years ago

Hmmm, no idea, sorry.

nitriques commented 10 years ago

Well, thanks anyway!

brendo commented 10 years ago

Sorry, in a similar boat to Michael. I haven't used Cachelite before. Ask on the forums perhaps? On 18 Nov 2014 04:53, "Nicolas Brassard" notifications@github.com wrote:

Well, thanks anyway!

— Reply to this email directly or view it on GitHub https://github.com/symphonists/cachelite/pull/24#issuecomment-63354720.

nitriques commented 10 years ago

Good idea: http://www.getsymphony.com/discuss/thread/108917/

nitriques commented 10 years ago

Maybe @creativedutchmen uses it ?

michael-e commented 10 years ago

We'll see, but I don't think so. AFAIK, he uses datasource caching (Cacheable Datasource) and more "advanced" frontend caching (i.e. Varnish).

nitriques commented 10 years ago

more "advanced" frontend caching (i.e. Varnish)

I wish I could use that...

creativedutchmen commented 10 years ago

Michael is right, Varnish it is for me. Sorry:)

On Tue, Nov 18, 2014 at 12:22 AM, Nicolas Brassard notifications@github.com wrote:

more "advanced" frontend caching (i.e. Varnish)

I wish I could use that...

Reply to this email directly or view it on GitHub: https://github.com/symphonists/cachelite/pull/24#issuecomment-63395802

nitriques commented 10 years ago

@creativedutchmen Thanks anyhow! @andrewminton told me he might test it...

andrewminton commented 10 years ago

@nitriques do you have a series of test criteria you want me to cover at all?

nitriques commented 10 years ago
  1. Website still works
  2. ?debug now works
  3. Loggued in users never gets the cache version
  4. Cache is valid accross browser
  5. Exclusions still works

Thanks !

andrewminton commented 10 years ago

Ok, on it.

andrewminton commented 10 years ago
  1. Website works fine with Cachelite enabled
  2. ?debug working fine
  3. No Cache when logged in
  4. Persistence of cache is fine
  5. Exclusion of pages works as expected but I'd like to try expiring the cache for a page which previously had a cached version and then got added to the exclusion list.. cache still exists if I don't use ?flush=site or ?flush
nitriques commented 10 years ago

cache still exists if I don't use ?flush=site or ?flush

I think this always been like that, am I right ?

andrewminton commented 10 years ago

Yes it is.. all good from my point of view.

nitriques commented 10 years ago

Great ! Thanks a lot Andrew!