Closed kanduvisla closed 13 years ago
Hi Giel,
Sorry I haven't commented on this or merged changes yet. The reason is that I have recently rewritten a lot of this extension and added some features I have been quietly planning for a long time. Unfortunately this makes the new version incompatible with what you have implemented.
I'm not convinced this is a sustainable approach moving forward, since the way I'm parsing text and storing keywords is becoming more complex. There are more plans for things I want this extension to achieve, so the internal structure is likely to change further over time.
What I might end up doing is creating a new branch of the version you applied your patch to, merging your code, and releasing that as-is, for posterity.
Hope that's OK with you. Thanks for taking the time to fork and extend this, I hope you're still finding it useful.
Keep up the good work!
Hi Nick!
I added support for the multilanguage extension i made to your search index extension. Here is a summary to give you an idea of the changes:
indexEntry()
-function, it checks if there are fields which are multilingual, and it stores data into the additional search-index-columns.data.search.php
, the query is slightly modified to check against the right data-column (so it picksdata_en
instead ofdata
for example)Offcourse on each 'critical' step I do a check to see if the multilanguage extension is installed. I also placed all my modifications between code comment blocks, so you can easily distinct them from your other code (and offcourse, you can use a diff tool).
I also came accross some bugs I fixed:
deleteIndexByEntry()
-function didn't delete anything when passed an arrayPlease let me know what you think of this update. We are currently building a multilingual site with your search index extension for the site search, so if we encounter other nasty bugs we can fix them in this project.
Kind regards,
Giel Berkers