symphonists / shopping_cart

Shopping cart for Symphony CMS
4 stars 1 forks source link

2.3 Update #2

Open designermonkey opened 11 years ago

designermonkey commented 11 years ago

Expecting a pull request or direct editing to bring to 2.3

michael-e commented 11 years ago

Wait for the 2.2.x cleanup. Should be a good place to start.

designermonkey commented 11 years ago

Agreed, then tag as new version, and then the same for 2.3 compat

andrewminton commented 11 years ago

Is someone takling a 2.2.x version right now? Or is it develop in own repos and merge ideas later down the line as discussed?

designermonkey commented 11 years ago

did you do some work on this already?

I will be working on this at some point very early January.

michael-e commented 11 years ago

In my effort to slightly improve the existing codebase I have moved further and further away. Meanwhile I have something completely different, and you wouldn't even name it Shopping Cart (because it can do more than that, and it favors a much more abstract aproach).

This also means that the future of the Shopping Cart is unclear. If either @designermonkey or me have better ideas or actually build better stuff, we will have to decide what to do with it. Merge it? Have several extensions? This can not be decided right now.

My guess is that the Shopping Cart will remain what it is: a very simple, but not very flexible solution to "transient (session) storage". So if you ( @andrewminton ) want to update it for Symphony 2.3, please go ahead. I am not working on this codbase anymore, and I won't need a 2.2.x-compatible version.

andrewminton commented 11 years ago

Ok make sense.

designermonkey commented 11 years ago

@michael-e can I see your code please, very interested a my coming project needs a more abstract approach, and I was going to just hack bits off the Shopping Cart.

You have my email ;o)