search

symphonists / subsectionmanager

Subsection management for Symphony.
Other
44 stars 32 forks source link

Work around a bug in jQuery outerHeight() and outerWidth() when called without argument #252

Closed frenkel closed 9 years ago

frenkel commented 10 years ago

So apparently the bugs I was experiencing were a combination of my jQuery version and subsectionmanager's JavaScript. The bug is described here: http://stackoverflow.com/questions/12093806/jquery-1-8-outer-height-width-not-working#answer-15607372

This pull request works around the problem by calling outerHeight and outerWidth with the default argument.

Many thanks to GitHub user houke, who found and fixed this.

nitriques commented 9 years ago

Why did you close it ?

frenkel commented 9 years ago

Because it was over a year old and it didn't seem like you wanted to merge it.

nitriques commented 9 years ago

it didn't seem like you wanted to merge it.

More like we did not had the time. Maybe it's still valid, but I do not use this anymore...

If you confirm that there's still a bug, I might pull it in.