search

symphonists / uniondatasource

A union datasources allows you to combine multiple datasources to output a single datasource for the primary purpose of a unified pagination.
13 stars 11 forks source link

No output of Source-DS-Parameters in Union-DS #35

Closed animaux closed 10 years ago

animaux commented 10 years ago

In the readme it states that parameters are passed through. This doesn’t seem to be the case.

Symphony 2.3.6 Union Datasource 1.0.4

nilshoerrmann commented 10 years ago

I can confirm this issue. @brendo, any idea why this is failing?

brendo commented 10 years ago

Confirmed (2.5), looking into it.

brendo commented 10 years ago

@nilshoerrmann @animaux Do you think you'd be able to test the integration branch on your 2.3.6 install and let me know if things are working for you? I'm just not sure if the changes I've made break pre 2.4 compatibility or not.

nilshoerrmann commented 10 years ago

I only have a 2.5 version to test on – so that doesn't help, I guess.

animaux commented 10 years ago

Seems to break in 2.3.6. No options are visible in the DS-editor when choosing union-datasource.

brendo commented 10 years ago

Ok, I think d21c6f722a276109f37bf53337dd75d732112fa3 broke pre 2.4 compatibility. For your immediate fix, does applying the fix in f5c226d help?

animaux commented 10 years ago

@brendo I tried to recapitulate this on a local installation but got entangled in other problems so I wasn’t able to try (I had a workaround for that site).

If anyone else needs this it’s good to have your hint immortalised here. :) Cheers!