search

symphonists / uniondatasource

A union datasources allows you to combine multiple datasources to output a single datasource for the primary purpose of a unified pagination.
13 stars 11 forks source link

Union DS does not resolve dependencies of included DSs #7

Closed michael-e closed 12 years ago

michael-e commented 12 years ago

As posted in the forum:

At the moment a Union DS can have its own dependencies array which would be resolved if the array was set correctly upon saving. (This is not the case, the array is always empty.)

But it would be much better to remove the dependencies array from the constructor function and actively resolve dependencies for every Datasource which is included in the Union Datasource.

brendo commented 12 years ago

@michael-e, I've pushed to integration if you'd like to have a test before I release 0.6 :)

michael-e commented 12 years ago

Confirmed that dependencies are written to the Union DS file. (According to our previous tests those dependencies should actually work as intended, but I have not verified this.)

Also confirmed that #5 is fixed.