"Sort By" is wrong on edit page

symphonists / uniondatasource

A union datasources allows you to combine multiple datasources to output a single datasource for the primary purpose of a unified pagination.

13 stars 11 forks source link

"Sort By" is wrong on edit page #8

Open michael-e opened 12 years ago

michael-e commented 12 years ago

On the edit page, the inactive sort by and sort order dropdowns don't show the right items. (On the index page, however, the order by column contains correct values.)

brendo commented 12 years ago

Hey @michael-e, can you provide a little more detail?

I haven't been able to reproduce in Firefox, Chrome or Safari :(

michael-e commented 12 years ago

I have verified the following with Safari (latest) and Firefox (latest) on my Mac:

Initial state:

Sort By: ---
Sort Order: ascending

Add first Datasource (Sort by: Date; Sort Order: descending). Result:

Sort By: Date
Sort Order: ascending (which is wrong)

(Sometimes "descending" is displayed, but I haven't found any logic behind this.)

Now save the Union DS. Result:

Sort By: position (a field which does not even exist in the DS's section)
Sort Order: descending (correct!)

brendo commented 12 years ago

Is this with the latest from master?

michael-e commented 12 years ago

Yes, tagged 0.6.

brendo commented 12 years ago

Hey @michael-e, can reproduce some of it (the Sort Order, not the Sort By column). Think I've fixed it up within 8c64a08, can you test?

michael-e commented 12 years ago

One step. It works during editing now, but it's still wrong after the Union DS has been saved.

brendo commented 12 years ago

Hmm, head scratch. Will have to have another dig around!

brendo commented 12 years ago

I think I finally fixed this on the integration branch :)

michael-e commented 12 years ago

I cherry-picked that commit, cause I am still on 2.2.5. Nope, doesn't seem to work. Perhaps some conflict?