search

symphonycms / docs.getsymphony.com

The official repository for the Symphony CMS documentation site
2 stars 2 forks source link

Auto-magically generated section navigation #13

Closed johnpuddephatt closed 9 years ago

bernardodiasc commented 9 years ago

hey @johnpuddephatt, I made some notes on the PR. Also let's use on .md file extension, to keep consistent. :)

Thank you!

johnpuddephatt commented 9 years ago

Sorry, my bad on the formatting :disappointed:

I've sorted most of this but have his a small snag: I want to set a default layout (so that it doesn't have to be set in each page file) but this applies the layout to javascript file too. I've tried setting the default to only apply to pages but this still causes the problem to occur.

I'll keep trying, hopefully find a fix shortly.

bernardodiasc commented 9 years ago

as far as I know, empty double --- will make jekyll build the file but not apply any layout. this is used in the json and js file, the first because is buit with liquid, the second because I need the site.baseurl there.

johnpuddephatt commented 9 years ago

This is true, but not if a default layout value is set in _config.yml. We don't have to do this but I think it makes sense as it means not having to set the layout on every page.

I found a fix which was to set the layout to a non-existent layout. The other option would be to create an empty layout file, but I'm not sure there would be any benefit to this.

Anyway, all working now. And hopefully the indentation is fixed, let me know if I've missed anything.

johnpuddephatt commented 9 years ago

The ability to only set a default by type is documented here btw, but I had no luck with it. It would have been my preferred solution. Despite putting type: "pages", the js file still got dropped onto the default layout.

bernardodiasc commented 9 years ago

does search.json need layout: none too?

johnpuddephatt commented 9 years ago

Yep – I'm not sure how I missed that. Search is working again now :relieved:

bernardodiasc commented 9 years ago

Fantastic! Great job mate!

johnpuddephatt commented 9 years ago

:smile: I'll try and make sure future PR's are a bit smoother – I'm still getting the hang of Git/GitHub and collaborative working!

bernardodiasc commented 9 years ago

Way to go! It's good to have opportunity to learn by doing. :)