Closed tmslnz closed 8 years ago
What's the advantages of adding it here ? I've doing it via the .htaccess and it works well.
I'll let @designermonkey (or anybody else) figure out if that's out of scope or not.
Maybe out of scope, but not everyone runs under Apache, and it’s simpler for me to toggle it from the preferences, and only for JIT responses (we use Symphony as an API / data backend for Express.js) The same could be said about the “Preserve ISP proxy transformation” setting, which itself add a response header…
Sorry, I don't get involved in scope any more.
Ok then! Would you mind editing the meta.xml file to create version 1.42 ? I'll release it after that.
Thank you. I’ve added an OPTIONS response after submitting the PR. I’d like to test it a bit more. Mind if I ping later when I’m ready? Also are we happy with the label's name? CORSS / cross-origin, etc That stuff is already confusing enough by itself, don’t want to add insult to injury by mis-labeling an input box :)
Mind if I ping later when I’m ready?
Not at all! Simply add commits to this PR.
Also are we happy with the label's name?
I think so!
Sorry, I don't get involved in scope any more.
If @designermonkey doesn't, we might wait for @brendo who definitely should (get involved).
Yup. But still needs a new version to be able to release it when Brendan comes back.
Sorry all, haven’t had time yet to run some sanity checks. Having fun with VAT returns :)
VAT is always fun. :-)
Manually rebased and merged in fa71743
Hello, This is a simple addition to the JIT preferences to allow setting a CORS header / value