symphonycms / jit_image_manipulation

Just in Time Image Manipulation for Symphony CMS
http://symphonyextensions.com/extensions/jit_image_manipulation/
Other
25 stars 42 forks source link

Feature CORS header support #108

Closed tmslnz closed 8 years ago

tmslnz commented 9 years ago

Hello, This is a simple addition to the JIT preferences to allow setting a CORS header / value

screen shot 2015-07-04 at 14 31 42
nitriques commented 9 years ago

What's the advantages of adding it here ? I've doing it via the .htaccess and it works well.

I'll let @designermonkey (or anybody else) figure out if that's out of scope or not.

tmslnz commented 9 years ago

Maybe out of scope, but not everyone runs under Apache, and it’s simpler for me to toggle it from the preferences, and only for JIT responses (we use Symphony as an API / data backend for Express.js) The same could be said about the “Preserve ISP proxy transformation” setting, which itself add a response header…

designermonkey commented 9 years ago

Sorry, I don't get involved in scope any more.

nitriques commented 9 years ago

Ok then! Would you mind editing the meta.xml file to create version 1.42 ? I'll release it after that.

tmslnz commented 9 years ago

Thank you. I’ve added an OPTIONS response after submitting the PR. I’d like to test it a bit more. Mind if I ping later when I’m ready? Also are we happy with the label's name? CORSS / cross-origin, etc That stuff is already confusing enough by itself, don’t want to add insult to injury by mis-labeling an input box :)

nitriques commented 9 years ago

Mind if I ping later when I’m ready?

Not at all! Simply add commits to this PR.

Also are we happy with the label's name?

I think so!

michael-e commented 9 years ago

Sorry, I don't get involved in scope any more.

If @designermonkey doesn't, we might wait for @brendo who definitely should (get involved).

nitriques commented 9 years ago

Yup. But still needs a new version to be able to release it when Brendan comes back.

tmslnz commented 9 years ago

Sorry all, haven’t had time yet to run some sanity checks. Having fun with VAT returns :)

michael-e commented 9 years ago

VAT is always fun. :-)

nitriques commented 8 years ago

Manually rebased and merged in fa71743