Suggestion: handling SVG images

[animaux]

When an SVG-Image is sent to JIT it currently doesn’t do anything useful. Maybe JIT should just pass through the original SVG if it detects one?

[nitriques]

Hum... I've implemented something similar here and it creates lots of if else clause...

I really think that the supporting svg (just by "letting it pass through") is not a responsibility of this extension.

A simple xsl choose should be enough (we even have a xsl template that properly handles it).

I'd love to here what @brendo thinks about this.

[animaux]

A simple xsl choose should be enough (we even have a xsl template that properly handles it).

That’s what I did in the meantime. Maybe you’re right.

[nitriques]

Maybe you’re right.

But maybe I am not ;) But adding svg support would add a lot of complexity (if ... else ...) to the current code base. If we would refactor the code base to use the strategy pattern (one class for each mime type), it would not add a lot of complexity. But the current code base must be re-written for that.

[animaux]

I see. Thanks for the inside info :)

[nitriques]

My pleasure. I love to talk about those things :)

[animaux]

:)

I tried to think about the implications of applying JIT to SVG. I wonder if there are any libraries around?

[nitriques]

I wonder if there are any libraries around?

I do not know! Would be cool to be able to crop it! But you would not really save on bandwidth tho.

[animaux]

Thinking further most use-cases of SVG that come to mind will not be the kind of images one would like to be cropped … but then again who knows? Good to have all the possibilities :)

[nitriques]

Yup.