search

symphonycms / jit_image_manipulation

Just in Time Image Manipulation for Symphony CMS
http://symphonyextensions.com/extensions/jit_image_manipulation/
Other
25 stars 42 forks source link

Error handling and compatibility with alternate servers #119

Closed siimsoni closed 8 years ago

siimsoni commented 8 years ago

Better handling in environments with no .htaccess present (for example Nginx server). Updated handling error conditions to display relevant error messages.

nitriques commented 8 years ago

LGTM.

@brendo wanna test ?

brendo commented 8 years ago

Ideally the HtAccess class needs to be commented and should follow at least PSR-1 (and optimally PSR-2).

Concept is ok though.

siimsoni commented 8 years ago

The irony how I was avoiding PSR to keep things consistent... I will change it, thanks! :-)

siimsoni commented 8 years ago

I have updated the HTAccess class to PSR standard.

nitriques commented 8 years ago

Rebased and merged in integration as 7aaf6ac