Shouldn't be able to add a new recipe of type 'New recipe' - Githubissues

symphonycms / jit_image_manipulation

Just in Time Image Manipulation for Symphony CMS

http://symphonyextensions.com/extensions/jit_image_manipulation/

Other

25 stars 42 forks source link

Shouldn't be able to add a new recipe of type 'New recipe' #125

Open DavidOliver opened 8 years ago

DavidOliver commented 8 years ago

screenshot from 2016-06-08 14 22 21

In the New recipe adder, there's now a 'New Recipe' select option. Shouldn't this still be 'Direct display' as in previous versions?

nitriques commented 8 years ago

'Direct display' has never been documented (I was not even aware it existed before I found the rule about it). It was also not implemented in @brendo's refactor into a symphony renderer.

We should add a warning in the README and release notes about this removal.

DavidOliver commented 8 years ago

Okay, thanks. So the ability to add a new recipie with the 'New recipe' option needs to be disabled then. Renaming issue.

nitriques commented 8 years ago

Perf!

[x] ~~disable button when 'New recipe' is selected~~ Remove the deprecated option completely
[x] We should add a warning in the README and release notes about this removal.

nitriques commented 8 years ago

This should also be fixed in the latest integration

DavidOliver commented 8 years ago

Thanks! I notice the removal of direct mode isn't mentioned in the readme. Will it be noted in the release notes at GitHub?

nitriques commented 8 years ago

Well direct mode was never part of the readme. But yeah, it will be noted in the release notes on GitHub

DavidOliver commented 8 years ago

Okeydoke. I only mentioned it as you listed it being in the readme as a todo above. Thanks a lot for sorting this.

nitriques commented 8 years ago

Thanks for testing!