symphonycms / jit_image_manipulation

Just in Time Image Manipulation for Symphony CMS
http://symphonyextensions.com/extensions/jit_image_manipulation/
Other
25 stars 42 forks source link

readme doesn't contain the latest Apache rewrite rule #126

Closed DavidOliver closed 8 years ago

DavidOliver commented 8 years ago

If I understand correctly, the rule has been simplified so as not to include file type extensions. (Is this because JIT now checks image type itself?) The readme doesn't yet contain the simplified rule.

By the way, it's useful to have the rule in the readme as we do for those of us who need to convert the rule to non-Apache rewrites.

nitriques commented 8 years ago

The readme doesn't yet contain the simplified rule.

This move was made years ago. It never caught my eyes that it did and I integrated a regression doing so (See #75 )

A 2.1.0 update section will be created. Thanks!

nitriques commented 8 years ago

Done! @DavidOliver Can you please review ? Thanks!

DavidOliver commented 8 years ago

Cool - thanks.