search

symphonycms / jit_image_manipulation

Just in Time Image Manipulation for Symphony CMS
http://symphonyextensions.com/extensions/jit_image_manipulation/
Other
25 stars 42 forks source link

1.3 JIT update not indicated by Symphony backend #86

Closed jurajkapsz closed 10 years ago

jurajkapsz commented 10 years ago

Not sure why, but after uploading the v1.3 into Symphony 2.4RC2, the update to v1.3 is not indicated at /symphony/system/extensions/.

jensscherbl commented 10 years ago

Previous version is actually 1.21 (not 1.2.1), so the new version number 1.3 is not correct. Fixed it in #87 by setting the version number to 1.30.

brendo commented 10 years ago

OK, sure. Submit a pull request against all extensions updating them to 2.0.0. Then submit one against the core for 3.0.0.

brendo commented 10 years ago

Or do all extensions to 3.0.0 and if an extension starts with 3 it'll be compatible with core 3 etc. On 23 Jun 2014 08:59, "Brendan Abbott" brendan@bloodbone.ws wrote:

OK, sure. Submit a pull request against all extensions updating them to 2.0.0. Then submit one against the core for 3.0.0.

jensscherbl commented 10 years ago

I removed my comment about semver because I realized that it wasn't really the problem in this case.

But that would still be a good thing to do, right?