search

symphonycms / jit_image_manipulation

Just in Time Image Manipulation for Symphony CMS
http://symphonyextensions.com/extensions/jit_image_manipulation/
Other
25 stars 42 forks source link

Jit renderer #98

Closed brendo closed 8 years ago

brendo commented 9 years ago

This pull request (and branch) is a major overhaul to the architecture of JIT. Instead of a standalone script, JIT is simply another Renderer which inherits all Symphony functionality. This was made possible by Symphony 2.5, which added the ModifySymphonyLauncher delegate. This alleviates the major limitation of JIT in that it can now use delegates.

I believe this change would make it possible to fix the following by adding in delegates, or with minor changes to the code:

The code in this pull request is far from release quality, but I've pushed up in response to the comment by @jensscherbl that others could probably run with this better than I can. Math and image manipulation are not my strengths, so I'm happy for interested parties to carry on this work and work towards a 2.0 release!

jensscherbl commented 9 years ago

The launcher thing is interesting. I thought about another approach a while ago and would like to hear your opinion on that.

What if we reuse existing Symphony functionality for this? Using pages with an image page type, URL parameter and image data source to create recipes?

Modifications could then be defined on a data source level, similar to what we're discussing for text formatters.

brendo commented 9 years ago

What if we reuse existing Symphony functionality for this? Using pages with an image page type, URL parameter and image data source to create recipes?

Modifications could then be defined on a data source level, similar to what we're discussing for text formatters.

Interesting. Seems a little cumbersome though? The whole Symphony stack has to be loaded to process an image.

jensscherbl commented 9 years ago

The whole Symphony stack has to be loaded to process an image.

Wouldn't that be the case anyway for using the ModifySymphonyLauncher delegate?

But yeah, I guess you're right, would be a little cumbersome.

bernardodiasc commented 9 years ago

This is great!

jonmifsud commented 9 years ago

@brendo just noticed this - if I understand correctly at this point this does exactly the same thing as JIT currently does right now. And would need to be extended through delegates to tackle the issues you listed correct? If so I can have a look to see if it would help close #97 as I had to add a few other functions when extending the Image class such as a __clone function though that could be added to the main class I presume.

brendo commented 9 years ago

And would need to be extended through delegates to tackle the issues you listed correct?

Yeah correct :)

nitriques commented 9 years ago

+1000 in this thing @brendo

nitriques commented 8 years ago

Merged as https://github.com/symphonycms/jit_image_manipulation/compare/0f72a2c...18a2b02

Rebased is identical to original: https://github.com/symphonycms/jit_image_manipulation/compare/3629d85..2d8ed7d...0f72a2c..18a2b02