search

symphonycms / symphonycms

This is the official Symphony CMS repository.
https://www.getsymphony.com
MIT License
544 stars 212 forks source link

Brackets in field handles not transliterated (removed) anymore #2900

Closed animaux closed 5 years ago

animaux commented 5 years ago

Affected Symphony version(s) : 2.7.10 (since some version after 2.7.7) PHP version(s) : 7.3 OS(es) : all

Brackets used to be removed for autmatically created field handles. After creating a new field with brackets in its name, now this comes up, and the handles have to be cleared manually:

Bildschirmfoto 2019-04-25 um 10 00 45

cylkee commented 5 years ago

Is this related to #2890?

animaux commented 5 years ago

Oh yes, sorry it’s a duplicate!

michael-e commented 5 years ago

@animaux your issue is in your language extension (https://github.com/animaux/lang_german/blob/02ff2d44270000a32475d1b4b2cb70781a4dcb5c/lang/lang.de.php#L2145), which must be fixed as well. We only fixed it in the core.

animaux commented 5 years ago

Thanks @michael-e! Will this break the extension for older symphony versions?

michael-e commented 5 years ago

The bug was introduced in 2.3RC1 (https://github.com/symphonycms/symphony-2/commit/6983d12cf2d5f28935b1b0fd6bdeb00e234cbb9e). So yes, theoretically it would break the extension for Symphony < 2.3.

animaux commented 5 years ago

OK thanks. Strange that it worked fine all the time since then …

michael-e commented 5 years ago

Yep (see https://github.com/symphonycms/symphony-2/issues/2890#issue-416526962):

It is almost unbelievable that we have not noticed this very old bug before.

No idea why.

animaux commented 5 years ago

¯_(ツ)_/¯ The mysteries of complex software!