BlackRock changes - Githubissues

ghost commented 6 years ago

When calling getAllUsers() the method queries for all Symphony user ids, and then creates a bunch of threads that each queries Symphony POD for the information about a user id. The code currently allows 5 seconds for all users to be returned. After 5 seconds it returns the subset of users that have been added; in BlackRock this means calls to getAllUsers() only returns one third of all users. Additionally the flag indicating if a given SymUser is active, e.g. their account is enabled, is not set.

This pull request:

Leaves the default time for waiting for all user data to be returned (unchanged) at 5 seconds
Allows the default time to be modified by setting SYMPHONY_GET_ALL_USERS_TIMEOUT as a VM argument, e.g. for 2 minutes -DSYMPHONY_GET_ALL_USERS_TIMEOUT=120
Sets the active flag on SymUser when calling getAllUsersWithDetails()

ghost commented 6 years ago

Updated code in line with previous comments.

Thoughts?

ghost commented 6 years ago

I will merge this pull request on Tuesday 16th October (2 weeks away).

Please raise any concerns prior to this date.

symphonyoss / symphony-java-client

BlackRock changes #121