search

symphonyoss / symphony-java-client

Java client library for Symphony
Apache License 2.0
34 stars 37 forks source link

Decouple Certificates from File Read #128

Open UncleFirefox opened 5 years ago

UncleFirefox commented 5 years ago

Hi,

In order to initialize the SymClient on always has to pass into the configuration actual file paths to read from files. In the microservices architecture I'm working with it's not really a good practice to embed files that they can be read from a library. Would there be a way to inject a certificate via a string/parameter in order to make it more Helm friendly?

Thanks

UncleFirefox commented 5 years ago

I think it could be as simple is making JwtHelper.parseRSAPrivateKey to have an overload that takes directly a string which could be injected in the SymConfig class as a parameter then on authenticate method from SymBotRSAAuth try first with the new string otherwise use the classic File based approach instead.