search

symphonyoss / symphony-java-client

Java client library for Symphony
Apache License 2.0
34 stars 37 forks source link

Make DataFeedListener public #77

Closed dferguson992 closed 6 years ago

dferguson992 commented 7 years ago

Change DataFeedWorker's access level to public. Otherwise no one can use it.

ftbb commented 7 years ago

Never intended to be public as it should only be accessible via "Services".

Services hide away all the underlying event management and expose higher level functions.

Datafeed underpins the "MessageService" that underpins all other services. see: https://github.com/symphonyoss/symphony-java-client/wiki/Overview

A user always has the ability to create their own datafeed implementation and event management utilizing the client interfaces. With this said, they would probably be reproducing the wheel in the end when it comes to satisfying the most common use cases that the existing "Services" already provide.