search

symphonyoss / symphony-java-sample-bots

A set of simple Bots for Symphony, implemented in Java.
Apache License 2.0
20 stars 14 forks source link

Startup scripts don't support proxies #18

Open pmonks opened 6 years ago

pmonks commented 6 years ago

To facilitate onboarding of new Symphony pod developers working in HTTP proxy environments (i.e. most firms), the env.sh script should include options for setting:

The enhanced run-bot.sh script (see issue #17) should then include these options in the JVM's startup command line (i.e. via -Dhttp.proxyHost=${PROXY_HOST} -Dhttp.proxyPort=${PROXY_PORT} -Dhttp.proxyUser=${PROXY_USERNAME} -Dhttp.proxyPassword=${PROXY_PASSWORD}).

maoo commented 6 years ago

Thanks for raising this @pmonks . I've followed SJC docs and added a proxy.url item in symphony.properties config file; the README explains how to set it up.

It works as expected, however, I didn't see any mention to port, username or password configuration.

Code is in this block of Utils.java, if you want to review.