Closed learning-chip closed 1 year ago
The unit tests should also run within github workflows for automatic CI. Currently only the demo examples get run, which is not sufficient for validating advanced features.
Thank you, adding test to the flow was on my long list.
Enabling unit test would help capture bugs like #5, and also allow better validation of new functionalities like https://github.com/sympiler/sympiler/issues/7 . This PR is just to enable the existing test
sptrsv_tests.cpp
; will add more tests in later PRs.Currently the Catch test target is commented out:
https://github.com/sympiler/aggregation/blob/da104fa343672469f2000efa4285dccb32107370/CMakeLists.txt#L151-L153
Uncommenting the lines leads to compile errors with gcc-11.3:
Updating to the latest Catch v2.13.10 solves the bug. Still using the single-header v2 branch of Catch, not yet changing to the multi-header v3 branch.
Also changed the include files from
Sparse_BLAS_INC
toSparse_TRSV_INC
, andSparse_BLAS_SRC_FILES
toSparse_TRSV_SRC_FILES
, since the former is not defined elsewhere even in the parent Sympiler repo.